fix: adjust test for static method invocation

Signed-off-by: ernolf <[email protected]>
nextcloud · Aug 8, 2024 · 800c808 · 800c808
1 parent bf4f8e7
commit 800c808
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/tests/Unit/Controller/SettingsControllerTest.php b/tests/Unit/Controller/SettingsControllerTest.php
@@ -109,17 +109,28 @@ public function testCreateSecret() {
 			->method('getCloudId')
 			->willReturn('[email protected]');
 
-		$secret = 'newsecret';
-		$algorithm = ITotp::getAlgorithmById(1);
-		$digits = 6;
-		$period = ITotp::DEFAULT_PERIOD;
+		$this->totp->expects($this->once())
+			->method('createSecret')
+			->with($user, null, 1, 6, 30)
+			->willReturn('newsecret');
+
+		// Mock the default algorithm and digits
+		$this->totp->expects($this->once())
+			->method('getDefaultAlgorithm')
+			->willReturn(1);
+		$this->totp->expects($this->once())
+			->method('getDefaultDigits')
+			->willReturn(6);
+
+		// Mock method for `getAlgorithmById`
+		$this->totp->method('getAlgorithmById')->willReturn('SHA1');
 
 		$issuer = rawurlencode($this->defaults->getName());
-		$qrUrl = "otpauth://totp/{$issuer}:user%40instance.com?secret=$secret&issuer=$issuer&algorithm=SHA1&digits=$digits&period=$period&image=";
+		$qrUrl = "otpauth://totp/{$issuer}:user%40instance.com?secret=newsecret&issuer=$issuer&algorithm=SHA1&digits=6&period=30&image=";
 
 		$expected = new JSONResponse([
 			'state' => ITotp::STATE_CREATED,
-			'secret' => $secret,
+			'secret' => 'newsecret',
 			'qrUrl' => $qrUrl
 		]);