-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(apps): Use constructor property promotion when possible #48790
base: master
Are you sure you want to change the base?
refactor(apps): Use constructor property promotion when possible #48790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked apps/dav and some other random samples. Can't see any issues
In terms of backporting I'm a fan of not doing it, unless it's touched anyway 🙈 |
I would not backport this, I tried to apply it locally and there are too many conflicts that are not worth spending the time on. |
|
As far as I can tell it just removes the property and adds the promotion in the constructor. That means if the injection uses the interface we will also use that internally. Judging from the failed tests and the psalm results this doesn't seem to cause problems with every used method already being in the interface (which is really good 🎉) |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
8b512ea
to
d361ac9
Compare
Only problem I found was where the property was called |
Summary
Done with rector. Maybe this PR is a bit too big, I can make separate PRs for individual apps if needed.
Checklist