Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Ci fixes #48213

Merged
merged 23 commits into from
Oct 9, 2024
Merged

[stable28] Ci fixes #48213

merged 23 commits into from
Oct 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 19, 2024

Backport of #48205

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews php Pull requests that update Php code CI labels Sep 19, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.11 milestone Sep 19, 2024
@artonge artonge changed the title [stable28] [stable30] Ci fixes [stable28] Ci fixes Sep 19, 2024
@icewind1991 icewind1991 marked this pull request as ready for review September 19, 2024 19:40
@icewind1991
Copy link
Member

had to include a variation of #48224 here: 774227d

@icewind1991
Copy link
Member

Added #48235

@Altahrim Altahrim mentioned this pull request Oct 1, 2024
2 tasks
@artonge
Copy link
Contributor

artonge commented Oct 2, 2024

Two remaining errors:

There were 2 failures:

1) OCA\Files_Trashbin\Tests\StorageTest::testCrossStorageDeleteFile
Failed asserting that 0 matches expected 1.

/home/runner/actions-runner/_work/server/server/apps/files_trashbin/tests/StorageTest.php:232

2) OCA\Files_Trashbin\Tests\StorageTest::testCrossStorageDeleteFolder
Failed asserting that 0 matches expected 1.

/home/runner/actions-runner/_work/server/server/apps/files_trashbin/tests/StorageTest.php:259

@icewind1991 is this from your changes, or shall we find someone else?

Signed-off-by: Louis Chemineau <[email protected]>
icewind1991 and others added 22 commits October 8, 2024 18:14
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…store

otherwise this causes confusion down the line as it's contents will be moved to the new cache

Signed-off-by: Robin Appelman <[email protected]>
@sorbaugh sorbaugh merged commit b97a88a into stable28 Oct 9, 2024
55 of 56 checks passed
@sorbaugh sorbaugh deleted the backport/48205/stable28 branch October 9, 2024 15:33
@blizzz blizzz mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug CI php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants