Skip to content

Commit

Permalink
Fix float and clear
Browse files Browse the repository at this point in the history
Signed-off-by: Mostafa Ahangarha <[email protected]>
  • Loading branch information
ahangarha committed Dec 24, 2023
1 parent 0e35bfa commit 68b9e74
Show file tree
Hide file tree
Showing 14 changed files with 95 additions and 26 deletions.
2 changes: 1 addition & 1 deletion core/css/apps.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/css/apps.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 27 additions & 2 deletions core/css/apps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ kbd {
/* counter can also be inside the link */
> .app-navigation-entry-utils {
display: inline-block;
float: right;
/* Check Floating fix below */
.app-navigation-entry-utils-counter {
padding-inline-end: 0 !important;
}
Expand Down Expand Up @@ -671,6 +671,24 @@ kbd {
}
}

/* Floating fix */
/* Cannot use inline-start and :dir to support Samsung Internet */
body[dir='ltr'] {
.app-navigation-personal,
.app-navigation-administration {
> ul > li > ul > li > a > .app-navigation-entry-utils {
float: right;
}
}
}
body[dir='rtl'] {
.app-navigation-personal,
.app-navigation-administration {
> ul > li > ul > li > a > .app-navigation-entry-utils {
float: left;
}
}
}

/* CONTENT --------------------------------------------------------- */
#content {
Expand Down Expand Up @@ -980,12 +998,19 @@ $min-content-width: variables.$breakpoint-mobile - variables.$navigation-width -
}
}
.tabsContainer {
clear: left;
.tab {
padding: 0 15px 15px;
}
}

/* Cannot use inline-start to support Samsung Internet*/
body[dir='ltr'] .tabsContainer {
clear: left;
}
body[dir='rtl'] .tabsContainer {
clear: right;
}

/* POPOVER MENU ------------------------------------------------------------ */
$popoveritem-height: 44px;
$popovericon-size: 16px;
Expand Down
2 changes: 1 addition & 1 deletion core/css/global.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/global.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 42 additions & 10 deletions core/css/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,52 @@

/* Global Components */

.pull-left {
float: left;
}
/* The following lines are a hacky way to adjust float and clear based on direction.
Samsung Internet doesn't support `inline-start|end` and :dir.
pull-right|left and clear-right|left are also kept for backward compatibility.
*/
body[dir='ltr'] {
.pull-left,
.pull-start {
float: left;
}

.pull-right {
float: right;
}
.pull-right,
.pull-end {
float: right;
}

.clear-left,
.clear-start {
clear: left;
}

.clear-left {
clear: left;
.clear-right,
.clear-end {
clear: right;
}
}

.clear-right {
clear: right;
body[dir='rtl'] {
.pull-left,
.pull-start {
float: right;
}

.pull-right,
.pull-end {
float: left;
}

.clear-left,
.clear-start {
clear: right;
}

.clear-right,
.clear-end {
clear: left;
}
}

.clear-both {
Expand Down
2 changes: 1 addition & 1 deletion core/css/guest.css

Large diffs are not rendered by default.

Loading

0 comments on commit 68b9e74

Please sign in to comment.