-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): introduce configuration builder #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
force-pushed
the
feat/config-builder
branch
5 times, most recently
from
May 16, 2024 13:27
68d8594
to
6d77807
Compare
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
May 16, 2024 13:43
d91c525
to
9f85c31
Compare
Altahrim
force-pushed
the
feat/config-builder
branch
from
May 16, 2024 13:48
9f85c31
to
df16b75
Compare
This was referenced May 19, 2024
Open
Nice! Since you're already stuffing the branch eol date into the json, this would be an ideal opportunity for #1050. This would let me do this: nextcloud/server#45402 (comment) |
kesselb
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
May 22, 2024 06:42
c3b6815
to
c32aa58
Compare
skjnldsv
reviewed
May 22, 2024
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
May 22, 2024 13:05
8ea3d28
to
280a290
Compare
Rebased for latest |
AndyScherzinger
approved these changes
May 22, 2024
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
May 27, 2024 14:03
db138d4
to
7d8f66f
Compare
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
feat/config-builder
branch
from
May 27, 2024 14:23
11aaab6
to
639a566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Introduce a configuration builder based on JSON files:
major_versions.json
declare all Nextcloud major versions with end of life and minimal supported PHP versionreleases.json
list all releases with their attributes (signature, internal version number and deploy percentage)The builder should be able to generate the
config.php
we are used to.TODO
README.md