[로또 미션] 황현식 미션 제출합니다. #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class Constant { | ||
|
|
||
| public static final int MAX_NUM = 45; | ||
| public static final int MIN_NUM = 1; |
|
|
||
| private void verifyRangeNumber(int number) { | ||
| if (number > Constant.MAX_NUM || number < Constant.MIN_NUM) { | ||
| throw new IllegalArgumentException("잘못된 범위의 숫자 입니다. 번호: " + number); |
Comment on lines
26
to
29
| if (this == o) | ||
| return true; | ||
| if (o == null || getClass() != o.getClass()) | ||
| return false; |
| private final List<Integer> numbers; | ||
|
|
||
| public RandomNumberGenerator() { | ||
| numbers = IntStream.rangeClosed(Constant.MIN_NUM, Constant.MAX_NUM) |
Comment on lines
+43
to
+49
| try { | ||
| Winnings winnings = Winnings.of(matchCount, bonusNumber); | ||
| this.winningsResult.merge(winnings, 1, Integer::sum); | ||
| prize += winnings.getWinningPrize(); | ||
| } catch (NoSuchElementException ignore) { | ||
|
|
||
| } |
There was a problem hiding this comment.
일치하는 수가 3개 미만인 것들은 무시하려고 쓴 부분인데
등수 외를 나타내는 상수를 쓰는게 더 좋은 방법 같네요!
src/main/java/view/ResultView.java
Outdated
Comment on lines
18
to
34
| for (Lotto lotto : lottoList) { | ||
| List<Integer> lottoNumber = lotto.getLottoNumber().stream() | ||
| .map(LottoNumber::getNumber) | ||
| .toList(); | ||
| System.out.println(lottoNumber); | ||
| } | ||
| } | ||
|
|
||
| public static void printWinningState(Map<Winnings, Integer> result, double rateOfResult) { | ||
| System.out.println("당첨 통계 \n--------"); | ||
| for (Winnings winnings : Winnings.values()) { | ||
| System.out.println(String.format(getResultMessage(winnings), | ||
| winnings.getMatchCount(), | ||
| winnings.getWinningPrize(), | ||
| result.get(winnings))); | ||
| } | ||
| System.out.println(String.format("총 수익률은 %.2f입니다.", rateOfResult)); |
Comment on lines
+37
to
+41
| public static String getResultMessage(Winnings winnings) { | ||
| if (winnings == Winnings.SECOND_PLACE) { | ||
| return "%d개 일치, 보너스 볼 일치(%d원)- %d개"; | ||
| } | ||
| return "%d개 일치 (%d원)- %d개"; |
| import domain.LottoNumber; | ||
| import domain.LottoStatus; | ||
|
|
||
| class LottoTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드에 대해 고민을 많이 해보는 좋은 시간이였던 것 같습니다.
다 짜고 나서 리팩터링 하는건 참 힘들다는 걸 깨달았습니다..
앞으론 처음부터 많이 생각하면서 작성하겠습니다.
코드가 아직 지저분해서 따로 더 고민해볼 생각입니다.
리뷰 잘 부탁드립니다!