[로또 미션] 이현수 미션 제출합니다 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choon0414
approved these changes
Jul 11, 2024
| OutputView outputView = new OutputView(); | ||
| LottoGame lottoGame = new LottoGame(inputView, outputView); | ||
| lottoGame.play(); | ||
| } |
There was a problem hiding this comment.
혹시 main과 별도의 실행 클래스를 분리하는 이유가 있나요?
잘 몰라서 여쭤봅니다!
| private static Lotto generateLottoNumber() { | ||
| Set<LottoNumber> lottoNumbers = IntStream.generate(() -> ThreadLocalRandom.current().nextInt(1, 46)) | ||
| .distinct() | ||
| .limit(6) |
There was a problem hiding this comment.
어멋.. 생각해보니 제가 예외처리를 꼼꼼하게 못한것같네요.. ㅠ
src/main/java/view/OutputView.java
Outdated
| } | ||
|
|
||
| private void printResult(Rank rank, Integer count) { | ||
| String bonus = rank.containsBonus()? ", 보너스 볼 일치": " "; |
There was a problem hiding this comment.
삼항연산자를 쓰지 말라는 조건이 있었습니다!
그래도 확실히 삼항연산자를 쓰는게 더 간결해지고 보기 편하네요!
|
|
||
| public void printMyLottos(List<Lotto> manual, List<Lotto> auto) { | ||
| System.out.println(String.format("수동으로 %d장, 자동으로 %d개를 구매했습니다.", manual.size(), auto.size())); | ||
| manual.stream().forEach(System.out::println); |
There was a problem hiding this comment.
오.. 그러고 보니 println을 스트림으로 써 볼 생각을 못했네요.
src/main/java/model/LottoGame.java
Outdated
| List<Lotto> autoLottos = RandomLottoGenerator.generateLottoNumbers(autoCount); | ||
| outputView.printMyLottos(manualLottos, autoLottos); | ||
| Lotto winningLotto = inputView.readWinningLotto(); | ||
| Integer bonusNumber = inputView.readBonusNumber(); |
There was a problem hiding this comment.
입력한 보너스 번호가 이미 뽑힌 번호 중에 있지 않은지에 대한 검증이 필요하다고 생각합니다
| import java.util.Arrays; | ||
|
|
||
| public enum Rank { | ||
| _LAST(0, 0, false), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이번주차는 stream을 최대한 많이 사용해보려고 했습니다.
확실히 stream을 사용하는게 가독성측면에서 더 좋다는 느낌을 받았습니다.
추가로 원시값과 컬렉션을 포장하여 사용하면 얻을 수 있는 장점이 많다는 것을 느꼈습니다.(예외처리와 같은 부분)
리뷰 잘부탁드립니다!