[Step3] 즐겨찾기 기능 구현 리뷰 요청드립니다. #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkeeseul
requested changes
Feb 22, 2022
Comment on lines
+63
to
+98
| @DisplayName("즐겨찾기 추가 하기") | ||
| @Test | ||
| public void addFavorite() { | ||
| // when | ||
| ExtractableResponse<Response> response = 즐겨찾기_생성_요청(로그인토큰, 강남역, 양재역); | ||
|
|
||
| // then | ||
| 즐겨찾기_생성됨(response); | ||
| } | ||
|
|
||
| @DisplayName("즐겨찾기 조회 하기") | ||
| @Test | ||
| public void getFavorites() { | ||
| // given | ||
| 즐겨찾기_생성_요청(로그인토큰, 강남역, 양재역); | ||
| 즐겨찾기_생성_요청(로그인토큰, 양재역, 교대역); | ||
|
|
||
| // when | ||
| ExtractableResponse<Response> response = 즐겨찾기_목록_조회_요청(로그인토큰); | ||
|
|
||
| // then | ||
| 즐겨찾기_정보_조회됨(response, new Long[]{강남역, 양재역}, new Long[]{양재역, 교대역}); | ||
| } | ||
|
|
||
| @DisplayName("즐겨찾기 삭제 하기") | ||
| @Test | ||
| public void deleteFavorites() { | ||
| // given | ||
| ExtractableResponse<Response> createResponse = 즐겨찾기_생성_요청(로그인토큰, 강남역, 양재역); | ||
|
|
||
| // when | ||
| ExtractableResponse<Response> response = 즐겨찾기_삭제_요청(로그인토큰, createResponse); | ||
|
|
||
| // then | ||
| 즐겨찾기_삭제됨(response); | ||
| } |
There was a problem hiding this comment.
즐겨찾기 목록을 관리한다 에서 시나리오 형식으로 잘 작성해주셔서
해당 테스트들은 작성해주지 않아도 괜찮을 것 같아요 😄
| public class FavoriteService { | ||
| private final StationService stationService; | ||
| private final PathService pathService; | ||
| private final MemberRepository memberRepository; |
There was a problem hiding this comment.
memberRepository 를 사용하고 있지 않는데요,
즐겨찾기 생성, 조회, 삭제 시 유요한 memberId 인지 확인하지 않아도 될까요? 😄
|
|
||
| return PathResponse.of(path); | ||
| } | ||
|
|
||
| Path findPath(Station upStation, Station downStation) { |
|
|
||
| public class FavoriteResponse { | ||
| private Long id; | ||
| private Long memberId; |
There was a problem hiding this comment.
요구사항에 memberId 는 없네요!
요구사항을 확인해주세요 😄
| } | ||
|
|
||
| @PostMapping | ||
| public ResponseEntity<FavoriteResponse> createFavorite( |
Comment on lines
+26
to
+30
| Optional.ofNullable(result) | ||
| .orElseThrow(() -> { | ||
| throw new IllegalArgumentException("출발역과 도착역이 연결되어 있지 않습니다."); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Optional 을 사용하신 이유가 있으신가요?
어떠한 이점이 있나요? 😄
Suggested change
| Optional.ofNullable(result) | |
| .orElseThrow(() -> { | |
| throw new IllegalArgumentException("출발역과 도착역이 연결되어 있지 않습니다."); | |
| }); | |
| if (Objects.isNull(result)) { | |
| throw new IllegalArgumentException("출발역과 도착역이 연결되어 있지 않습니다."); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 이슬님~
마지막 단계 리뷰 부탁드립니다! 🙇🏼♀️