Step04 cucumber #418
Open
Step04 cucumber #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/nextstep/subway/documentation/PathDocumentation.java
boorownie
approved these changes
Jan 16, 2024
| public class PathStepDef implements En { | ||
|
|
||
|
|
||
| @Autowired |
There was a problem hiding this comment.
@Autowired 에 컴파일 에러가 뜨다니.. 확인해봐야겠네요
제 로컬에서는 안 뜨는데 플러그인 이슈일 수 있을 것 같기도..;;
큐컴버 사용 시 의존성 관리를 스프링으로 하는 방법으로 샘플을 작성했는데
pico-container라는 도구를 사용하는 방식도 있어요.
큐컴버가 스프링에 의존적이지 않게 하려면 이런 도구를 써야할 수 도 있겠네요.
Comment on lines
+44
to
+47
| When("{string}과 {string} 사이 경로를 조회하면", (String upStation, String downStation) | ||
| -> response = PathSteps.두_역의_거리_경로_조회를_요청( | ||
| context.get(upStation), context.get(downStation), PathRequestType.DISTANCE | ||
| )); |
There was a problem hiding this comment.
기존 스텝 메서드를 재활용 잘 해주셨네요 👍
실제로 제가 저희 팀에서 큐컴버로 마이그레이션 할 때 했던 방식이에요!
Comment on lines
+7
to
+21
| Scenario: 지하철역들을 생성하고 경로를 찾는다. | ||
| Given 지하철역들을 생성하고 | ||
| |name| | ||
| |교대역 | | ||
| |강남역 | | ||
| |양재역 | | ||
| |남부터미널역| | ||
| Given 지하철 노선들을 생성하고 | ||
| |name|color|upStation|downStation|distance|duration|surcharge| | ||
| |3호선 | orange | 교대역 | 남부터미널역 | 2 | 10 | 0 | | ||
| Given '3호선'에 지하철 역을 추가하고 | ||
| |upStation|downStation|distance|duration| | ||
| |남부터미널역 |양재역 |3 |10 | | ||
| When '교대역'과 '양재역' 사이 경로를 조회하면 | ||
| Then '교대역'-'남부터미널역'-'양재역' 경로가 조회된다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cucumber로 인수테스트 문서 만들어봤습니다. :)
PathStepDef에 공유객체(스프링 빈)을 주입하니, 인텔리제이에선 Autowired가 빨간줄 뜨네요. 😅
(과제할 때 merge가 안됐었나봐요. commit이 다 따라왔네요;;;)