Move error flow into guard

newscred · Sep 25, 2023 · 15e562e · 15e562e
1 parent 8d5e490
commit 15e562e
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/pages/api/config/validate.ts b/pages/api/config/validate.ts
@@ -8,19 +8,19 @@ const handler = async (req: NextApiRequest, res: Response) => {
 
   const shade = req.body.shade;
   const validShades = ["red", "green", "blue"];
-  if (shade == null || validShades.includes(shade)) {
-    res.status(200).json({ message: "OK" });
+  if (shade != null && !validShades.includes(shade)) {
+    res.status(422).json({
+      message: `Shade cannot be ${shade}`,
+      details: {
+        shade: {
+          message: `Shade cannot be ${shade}`,
+        },
+      },
+    });
     return;
   }
 
-  res.status(422).json({
-    message: `Shade cannot be ${shade}`,
-    details: {
-      shade: {
-        message: `Shade cannot be ${shade}`,
-      },
-    },
-  });
+  res.status(200).json({ message: "OK" });
 };
 
 type Response = NextApiResponse<{