Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: consolidate sync and async variations of MsSql integration tests #2095

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

nr-ahemsath
Copy link
Member

To help reduce execution time of the MsSql integration tests, this PR combines the sync and async versions of tests. A few overall points to note:

  • Sql traces are kept based on the SqlId which is based on the command/statement text. In order to get traces for both sync and async operations, a different table name is used for some sync vs. async operations, and the SELECT command text is altered (query by first vs last name) for the operations against the pre-existing teammembers table
  • Some assertions are varied depending on whether the sync or async transaction was sampled
  • An unused web-based test application was deleted
  • Some repeated constants of SQL text in the exercisers were refactored into a base class

@codecov-commenter
Copy link

Codecov Report

Merging #2095 (029f796) into main (ddee81d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   81.10%   81.07%   -0.03%     
==========================================
  Files         395      395              
  Lines       24711    24711              
  Branches     2969     2969              
==========================================
- Hits        20041    20034       -7     
- Misses       3886     3891       +5     
- Partials      784      786       +2     

see 1 file with indirect coverage changes

Copy link
Member

@nrcventura nrcventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice time savings of 8 minutes!

@nr-ahemsath nr-ahemsath merged commit eadaf4b into main Nov 27, 2023
75 checks passed
@nr-ahemsath nr-ahemsath deleted the test/consolidate-mssql-tests branch November 27, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants