-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove dependency on Serilog.Expressions. #2082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
November 17, 2023 16:23
nrcventura
reviewed
Nov 17, 2023
jaffinito
reviewed
Nov 17, 2023
jaffinito
approved these changes
Nov 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
- Coverage 81.11% 81.06% -0.06%
==========================================
Files 395 395
Lines 24697 24695 -2
Branches 2966 2966
==========================================
- Hits 20033 20019 -14
- Misses 3882 3890 +8
- Partials 782 786 +4
|
nr-ahemsath
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
nrcventura
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Remove dependency on Serilog.Expressions. Resolves #2083.
END_COMMIT_OVERRIDE
Description
Removes the dependency on the
Serilog.Expressions
package, which resolves issues experienced by some customers where the agent does not report data and does not create a log file.Added a new log enricher for the required timestamp format in the log file. Updated existing log enrichers to improve performance where possible.
An integration test was added to validate that the logfile output is in the expected format.
Resolves #2083
Props to @chynesNR for sleuthing this one!
Author Checklist
Reviewer Checklist