Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature work: log level filtering metrics #1767

Conversation

tippmar-nr
Copy link
Member

Adds metrics to track log lines discarded due to LogLevelDenyList configuration. Includes unit and integration tests.

I'm open to suggestions for different metric naming if folks don't like what I chose... ;-)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/log-level-filtering@30a18a0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##             feature/log-level-filtering    #1767   +/-   ##
==============================================================
  Coverage                               ?   82.61%           
==============================================================
  Files                                  ?      390           
  Lines                                  ?    24517           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    20254           
  Misses                                 ?     4263           
  Partials                               ?        0           

@nrcventura
Copy link
Member

Should the "dropped" metrics be incremented too?

@tippmar-nr
Copy link
Member Author

Should the "dropped" metrics be incremented too?

I don't think so, as that metric is for tracking logs that were dropped due to capacity constraints.

@tippmar-nr tippmar-nr merged commit 4e9e153 into feature/log-level-filtering Jul 12, 2023
70 of 74 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/log-level-filtering-metrics branch July 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants