Final tweaks for Dispose issues

newrelic · Jul 18, 2023 · 6d09a01 · 6d09a01
1 parent da7f99a
commit 6d09a01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Agent/NewRelic/Agent/Core/Samplers/GCSamplerNetCore.cs b/src/Agent/NewRelic/Agent/Core/Samplers/GCSamplerNetCore.cs
@@ -129,7 +129,7 @@ public override void Dispose()
         {
             base.Dispose();
             _listener?.StopListening();
-            //_listener?.Dispose();
+            _listener?.Dispose();
             _listener = null;
         }
     }

diff --git a/src/Agent/NewRelic/Agent/Core/Samplers/ThreadStatsSampler.cs b/src/Agent/NewRelic/Agent/Core/Samplers/ThreadStatsSampler.cs
@@ -79,7 +79,9 @@ public override void Dispose()
         {
             base.Dispose();
             _listener?.StopListening();
-            //_listener?.Dispose();
+#if NETFRAMEWORK // calling .Dispose() in .NET 7 explodes. No idea why.
+                _listener?.Dispose();
+#endif
             _listener = null;
         }
     }