Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XDR option and PortablePointer #3084

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Remove XDR option and PortablePointer #3084

merged 2 commits into from
Sep 24, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Sep 22, 2024

Both of them are unused.

In the same time replace DEBUG by a direct call to fprintf.

Copy link

sonarcloud bot commented Sep 22, 2024

Copy link

✔️ 97b349a -> Azure artifacts URL

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.40%. Comparing base (5928676) to head (97b349a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/ivoc/checkpnt.cpp 0.00% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3084   +/-   ##
=======================================
  Coverage   67.39%   67.40%           
=======================================
  Files         573      573           
  Lines      104927   104914   -13     
=======================================
- Hits        70716    70714    -2     
+ Misses      34211    34200   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alkino alkino requested a review from pramodk September 23, 2024 14:12
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the origin of XDR but LGTM.

cc: @nrnhines

@alkino alkino merged commit 0c3bfdd into master Sep 24, 2024
38 checks passed
@alkino alkino deleted the cornu/remove_xdr branch September 24, 2024 10:47
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to get rid of this stuff. PortablePointer was not even used in 2007 at the start of 6.2 development and is undoubtedly a misnomer. checkpnt probably belongs in the attic. It is a part of https://nrn.readthedocs.io/en/latest/python/simctrl/programmatic.html#checkpoint
which states

There is not enough implementation at this time to make this facility useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants