Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add SonarSource GitHub workflow #2550

Closed
wants to merge 1 commit into from
Closed

Conversation

tristan0x
Copy link
Member

No description provided.

@bbpbuildbot

This comment has been minimized.

@tristan0x tristan0x force-pushed the tristan0x/sonarsource branch 2 times, most recently from 561191e to 95e2dc2 Compare September 27, 2023 18:05
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2550 (eab0e72) into master (5868cdd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
- Coverage   61.49%   61.49%   -0.01%     
==========================================
  Files         623      623              
  Lines      119197   119198       +1     
==========================================
- Hits        73296    73295       -1     
- Misses      45901    45903       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 45ca40b -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 1075ac5 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ ec90e5e -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@ohm314
Copy link
Member

ohm314 commented Sep 28, 2023

Looks like it's in a good state now!
just one thing, I noticed this is running under a Bluebrain account on sonarcloud, can we maybe instead create a new account for neuronsimulator ? Otherwise we can get this merged, I think.

@tristan0x
Copy link
Member Author

Looks like it's in a good state now! just one thing, I noticed this is running under a Bluebrain account on sonarcloud, can we maybe instead create a new account for neuronsimulator ? Otherwise we can get this merged, I think.

I don't have the required privileges to do that. Can you give me administrative privileges on the repo for 24h?

@ohm314
Copy link
Member

ohm314 commented Oct 2, 2023

OK, I've granted you temporary access. Please let me know once you're done so that I can reset this.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@azure-pipelines
Copy link

✔️ eab0e72 -> Azure artifacts URL

@tristan0x
Copy link
Member Author

Now that the project has been setup from SonarCloud, the GitHub workflow complains that it is in "automatic" mode while it is trying to send a report.
I don't have access to the administrative board on https://sonarcloud.io/project/overview?id=neuronsimulator_nrn
Is there a location where you can instruct to exclude some directories in there @ohm314 ?

sonar.exclusions=cmake/**,external/**,docs/**

@ohm314
Copy link
Member

ohm314 commented Oct 23, 2023

(I think this PR can now be closed since it's all being done via the organization now)

@alkino
Copy link
Member

alkino commented Jan 29, 2024

Everything is done through the organization now.

@alkino alkino closed this Jan 29, 2024
@alkino alkino deleted the tristan0x/sonarsource branch January 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants