Regenerate ChangeLog file only if git metadata got updated
#2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is newer than .git/HEAD [networkupstools/nut-website#52] if test -e .git/HEAD && ( rm -f "`find "$@" -not -newer .git/HEAD`" || true ) 2>/dev/null && ls -la .git/HEAD "$@" 2>/dev/null ; then SKIP ; else WORK ; fi Hopefully this takes care of corner cases: * No .git/HEAD => WORK (may be unsuccessfully, maybe not - e.g. Git submodules referring to parent) * `rm` fails, maybe `find` returns empty => DON'T CARE, go to LS * `ls` fails (one of target files is absent - e.g. ChangeLog removed or never was there) => WORK Only if the ChangeLog is still there after the attempt on its life, SKIP and keep it Signed-off-by: Jim Klimov <[email protected]>
…le is newer than anything in a NUT_GITDIR (may be not "./git/" directly) [networkupstools/nut-website#52] Signed-off-by: Jim Klimov <[email protected]>
…kip/fail decisions [networkupstools/nut-website#52] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
enhancement
documentation
CI
jimklimov
added
the
refactor/fightwarn
…w that the parent Makefile knows when to slack off [networkupstools/nut-website#52] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
regen-changelog-only-if-new-git
branch
from
86d0118
to
d58dcb1
Compare
|
❌ Build nut 2.8.2.1726-master failed (commit 6ce59949d9 by @jimklimov) |
|
AppVeyor problem does not seem related to this change => #2437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for some faster development cycles (not causing
ChangeLogre-generation for every call that resolves tomake ChangeLog, and subsequently taking a minutes or two for the HTML/PDF variants of the huge file).Goes into guts of Git a bit too much, maybe, but this particular recipe is about being intimate with it anyway, and at worst we would keep generating the file when maybe we should not (if git repo filesystem backend design changes).
Should also help with networkupstools/nut-website#52 tangentially (at least regarding development cycles to fix that).
Example results in a
nut-websitebuild area (wherenutis a submodule):The actual impact is about HTML/PDF files however - or rather about avoiding the remakes where possible: