-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arubaAPs #2332
base: master
Are you sure you want to change the base?
Fix arubaAPs #2332
Conversation
Hey moetezz, I'd suggest that we should leave the product numbers (SKUs) as they were because they depend on the different areas in the world.
This is how it is done with most of the Aruba AP models. |
Hey @robinreinhardt, Thank you for your feedback. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates are the correct way to go for Aruba APs. Hopefully this will be merged soon! Thank you for this work!
@moetezz |
Under your request, I reverted the part number to reflect the model name. |
In my opinion, the SKU was the correct way to go. This would bring consistency across the portfolio. Then APs for other Regulatory Domains could be added. |
Fixed the WiFi interfaces for the Aruba APs since technically each WiFi radio, for example, 2.4GHz, 5GHz, and 6GHz, is an independent interface rather than one WiFi interface( in a use case a device might be connected using 2.4GHz signal to the AP thus it doesn't make it connected to the 5GHz), and this granularity makes it better.
Also fixed the console ports and power ports name to better fit the specs from the DataSheet.
Removed USB-A from console ports since they are not console ports.
FIxed Some Ethernet interfaces definition