added NIM-24A.yaml #2131
Open
added NIM-24A.yaml #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danner26
requested changes
May 18, 2024
| --- | ||
| manufacturer: Cisco | ||
| model: NIM-24A | ||
| part_number: NIM-24A |
There was a problem hiding this comment.
You are missing a lot of definitions. Please review other files and the main readme to see what should be defined
There was a problem hiding this comment.
Thank you for reviewing my pull request! I've added the module's weight and weight_unit fields, but I want to ensure we're covering all relevant information. Since it's a module-type, I wasn't able to find any more definitions, but I might be missing something. Do you have any suggestions for additional details or improvements we could include? I'm open to any feedback you have. Thanks again for your help!
danner26
added
the
status: revisions needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 👋
I noticed the NIM-24A module type was missing from the modules folder and i needed it for some experimenting in Netbox.
I added it in my local Netbox instance and I believe it would be beneficial to have it in the main repo.
If there is anything i missed or that need changing let me know and i will address them.
Looking forward to your feedback.