Persist logs on terminate if appropriate. #184
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @taun-fellowes! Thanks for the PR. It makes sense to me. Would it be possible to add a small unit test? Also, don't worry about CI failures on Elixir 1.11 or 1.12. I need to make a pass at updating this project for Elixir 1.17. I assume it will be a trivial update since I know Elixir 1.17 works fine, but a side effect will removing support for those older versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the logs are being persisted periodically, then it would also be useful if they are persisted as part of a terminate event to avoid losing logs to a
Nerves.Runtime.reboot/0.