Port django CMS 4 features #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update compatible with Django CMS version4 sitemap.py and cms_toolbars.py updated to support page menu and sitemap compatible with Django CMS version 4 Co-authored-by: Vipul, Narang <[email protected]>
…ms4 (#58) * Updated lastmod() to return latest publish version modified date if versioning is enabled. Co-authored-by: narender81 <[email protected]>
* Use the page toolbar from the CMS as this doesn't add more buttons. It's also designed fro use just on the page too * Functioning toolbar with versioning enabled * Added versioning test to ensure that the toolbar duplicated button issue never occurs again * Remove limit on versioning being installed. The test suite should run the same regardless of versioning
* Add filter to list only published pages in versioning is enabled/installed * Add test to check query performance Co-authored-by: narender81 <[email protected]>
Closed
5 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #83 +/- ##
===========================================
- Coverage 100.00% 98.92% -1.08%
===========================================
Files 9 9
Lines 152 186 +34
Branches 19 24 +5
===========================================
+ Hits 152 184 +32
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port changes from
support/4.x.0branch and #70 to latest developReferences
Fix #82
Checklist
inv lintchangesfile included (see docs)