Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: 3839 ckeditor only save changes if (really) dirty #3846

Merged
merged 3 commits into from
Sep 9, 2024
Merged

BUGFIX: 3839 ckeditor only save changes if (really) dirty #3846

merged 3 commits into from
Sep 9, 2024

Commits on Sep 5, 2024

  1. Revert "BUGFIX: Prevent unneccessary server calls when inline editor … 

    …is unchanged"

This reverts commit 180906d.

The change introduced with pr #3833 is not needed when onChange is only triggerd on real actual changes.
    @mhsdesign
    mhsdesign committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    26013a3 View commit details
    Browse the repository at this point in the history

  2. BUGFIX: 3839 & 3832 only issue changes if ckeditor is dirty 

    The dirty state can be tracked via the callback see ckeditor/ckeditor5#996 (comment)
    @mhsdesign
    mhsdesign committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9c85cef View commit details
    Browse the repository at this point in the history

  3. BUGFIX: 3839 & 3832 simplify change persistence by using .flush(); 

    ... and thus we can avoid the isDirty state and second change:data callback

> a flush method to immediately invoke them
    @mhsdesign
    mhsdesign committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1711617 View commit details
    Browse the repository at this point in the history