Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: #3303 Flush reflection cache for removed php classes #3383

Open
wants to merge 2 commits into
base: 9.0
Choose a base branch
from
Open

BUGFIX: #3303 Flush reflection cache for removed php classes #3383

wants to merge 2 commits into from

Commits on Jul 27, 2024

  1. BUGFIX: neos#3303 Flush reflection cache for removed php classes 

    There are a few layers to this bugfix.

1. Previously we ignored deleted files (see `file_exists`) and did not flush the `Flow_Reflection_Status` cache accordingly as we are not able to read the namespace from a deleted php file.
Now we do a best effort reverse lookup by going through all psr-4 autoload configurations and calculate a namespace under which composer would have found this file.

2. We introduce a state `removedReflectionDataClasses` like `updatedReflectionData` which will be used to check if we have to update the `ReflectionData` cache.
    @mhsdesign
    mhsdesign committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    4175b39 View commit details
    Browse the repository at this point in the history

  2. TASK: Simplify flushing interface implementations on deletion of class

    @mhsdesign
    mhsdesign committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ff5b41c View commit details
    Browse the repository at this point in the history