Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build action when running against a tag #40

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

jameswolff96
Copy link

Change fetch-depth to 0 on the checkout action closes neoforged#39
@Edivad99
Copy link

You should also update this:uses: gradle/gradle-build-action@v2
with this:uses: gradle/actions/setup-gradle@v3.
https://github.com/gradle/gradle-build-action

Copy link

@marchermans marchermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are already touching the gradle action, then it might be usefull to update the file in general. For example as suggested by updating the actions.

actions/setup-java@v2 -> actions/setup-java@v4
gradle/gradle-build-action@v2 -> gradle/actions/setup-gradle@v3
@jameswolff96
Copy link
Author

Updated the setup-java and gradle-build versions. Tested on push and release.

@Shadows-of-Fire Shadows-of-Fire merged commit d85c694 into neoforged:main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build action failing when creating a release
4 participants