Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of whitespaces on remove word #5138

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Improve handling of whitespaces on remove word #5138

merged 1 commit into from
Sep 6, 2024

Conversation

statiolake
Copy link
Contributor

Fixes remaining issue in #5134.

This fixes the issue where:

  • entire lines are removed on even if there are spaces in the middle, and
  • the initial spaces are not removed on .

@statiolake
fix(list): improve handling of whitespaces on remove word (neoclide#5137
b225dde 
)

This fixes the issue where:

- entire lines are removed on <C-w> even if there are spaces in the middle, and
- the initial spaces are not removed on <C-w>.
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (640544d) to head (b225dde).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5138   +/-   ##
=======================================
  Coverage   98.39%   98.40%           
=======================================
  Files         273      273           
  Lines       26131    26131           
  Branches     5400     5400           
=======================================
+ Hits        25711    25713    +2     
+ Misses        259      258    -1     
+ Partials      161      160    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit f3406e0 into neoclide:master Sep 6, 2024
4 checks passed
@statiolake statiolake deleted the fix/#5134-improve-list-remove-word branch September 6, 2024 16:46
@statiolake statiolake mentioned this pull request Sep 20, 2024
Merged
fannheyward added a commit that referenced this pull request Oct 12, 2024
@fannheyward
commit 9fd8578
57d488a 
9fd8578 Implement insert-mode like word deletion logic in coc lists (#5144)
07d6dc2 fix(document): use languageId to new LinesTextDocument (#5142)
f3406e0 fix(list): improve handling of whitespaces on remove word (#5137) (#5138)
640544d fix(list): improve regex to remove CJK word (#5137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fannheyward fannheyward fannheyward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@statiolake @fannheyward