Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inlayHint): more compact padding highlight group #4950

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kevinhwang91
Copy link
Contributor

If the chunk is an array with a single string, the highlight group only uses the foreground of Normal, which makes cursorline look better.

Reference: https://github.com/neovim/neovim/blob/0f85aeb478a68c18a8195e69724e1cb618fec058/runtime/lua/vim/lsp/inlay_hint.lua#L333-L337

If the chunk is an array with a single string, the highlight group only uses
the foreground of `Normal`, which makes `cursorline` look better.
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (b01ae44) to head (8ea23e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4950   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         273      273           
  Lines       26060    26060           
  Branches     5386     5386           
=======================================
  Hits        25686    25686           
  Misses        220      220           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit 846994b into neoclide:master Mar 21, 2024
3 of 4 checks passed
@kevinhwang91 kevinhwang91 deleted the inlay-padding-without-bg branch March 21, 2024 09:05
fannheyward added a commit that referenced this pull request Mar 26, 2024
9190bfe feat(list): add --buffer to list buffer diags (#4958)
fb030d4 fix(defaultAction) fallback to default action on emtpy expression (#4954)
846994b fix(inlayHint): more compact padding highlight group (#4950)
b01ae44 feat(semanticTokens)!: token highlight groups (#4667)
8c85d6f fix(markdown): incorrect list indentation alignment in markdown parser (#4884)
0d66554 fix(inlayHint): hl_mode = 'replace' for neovim (#4949)
1a8244e chore(package): update dependencies (#4948)
4f68722 feat(client): upgrade to marked 7 (#4947)
574c12c feat(package): @types/node@18 (#4946)
d299c66 feat(menu): C-j/k to navigate menu (#4945)
34d3d9d chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#4944)
aead8f4 chore(CI): use Node 20 (#4940)
@qiqiboy
Copy link
Contributor

qiqiboy commented Mar 28, 2024

inlayhint in vim9 not work from this commit

@fannheyward
Copy link
Member

inlayhint in vim9 not work from this commit

Reproduced

fannheyward added a commit that referenced this pull request Mar 28, 2024
related #4950

Set hl group for hint in Vim
fannheyward added a commit that referenced this pull request Mar 28, 2024
related #4950

Set hl group for hint in Vim
@fannheyward
Copy link
Member

@qiqiboy made a quick fix, set hl_group for hint in Vim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants