Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(website): add n3 popup to website #2513

Open
wants to merge 4 commits into
base: master-2.x
Choose a base branch
from
Open

feat(website): add n3 popup to website #2513

wants to merge 4 commits into from

Conversation

spencercorwin
Copy link
Collaborator

@spencercorwin spencercorwin commented Jul 12, 2021 •
edited
Loading

Description of the Change

  • Work-In-Progress: adding a popup to the legacy website that notifies the user that neo-one.io is for Neo Legacy and that N3 docs can be found at n3.neo-one.io
  • The added package (reactjs-popup) broke the React Static build process, so this PR is actually just a demonstration. This needs to be implemented without the reactjs-popup package
  • Also needed to remove some newer TypeScript language features in order to get the website to compile

How it looks:
Screen Shot 2021-08-05 at 6 57 12 PM

Test Plan

To run the website locally in dev mode:

  • Run rush compile-website-dev
  • When that is done (is very quick) run rush run-website-dev, which takes several minutes to finish
  • Then go to localhost:3000

Alternate Designs

See notes above.

Benefits

Clarity for users on which docs they are reading.

Possible Drawbacks

Applicable Issues

#2511
#2410

@spencercorwin spencercorwin added area/documentation Categorize issue or PR as documentation related area/website Categorize issue or PR as website (@neo-one/website) related do-not-merge/work-in-progress PR is not ready to be merged kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/documentation Categorize issue or PR as documentation related area/website Categorize issue or PR as website (@neo-one/website) related do-not-merge/work-in-progress PR is not ready to be merged kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencercorwin @ftgibran