-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configuring all params in alternative name models #2345
Merged
DjordyKoert
merged 5 commits into
nelmio:master
from
herndlm:alternative-names-options-serialization-context
Sep 30, 2024
Merged
feat: support configuring all params in alternative name models #2345
DjordyKoert
merged 5 commits into
nelmio:master
from
herndlm:alternative-names-options-serialization-context
Sep 30, 2024
+100
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
alternative-names-options-serialization-context
branch
2 times, most recently
from
September 27, 2024 10:00
684d4f2
to
72e6dc1
Compare
herndlm
force-pushed
the
alternative-names-options-serialization-context
branch
from
September 27, 2024 10:02
72e6dc1
to
f30d53b
Compare
fyi @DjordyKoert |
kevinpapst
reviewed
Sep 27, 2024
DjordyKoert
requested changes
Sep 27, 2024
adapted @DjordyKoert sorry for being impatient, but you think you can put this and the other serializationContext pass-through fix into the next release? 😊 |
DjordyKoert
approved these changes
Sep 30, 2024
@herndlm sorry had a busy weekend 😅 Anyways thank you for the PR's! ❤️ |
Thanks! I wasn't expecting you to check something here on the weekend, no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature parity to model creation in yaml via
nelmio_api_doc.models.names
by also supportingoptions
andserializationContext
.Tested in a local project, e.g.
lead to
inspired by #2342 (comment)
fyi @kevinpapst
it's the first time I touch this Symfony Config TreeBuilder stuff btw..