Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda-store environment name regression #46

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Follow-up to #43 which broke the extraction of environment from conda-store envs by overriding the original kernel object. Now the copy gets modified instead.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski added the bug label Jun 1, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-new-launcher/fix-conda_env_name-issue

@krassowski krassowski merged commit 5aafb2a into main Jun 1, 2024
8 checks passed
@krassowski krassowski deleted the fix-conda_env_name-issue branch June 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant