Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last used and favourite tracking issues #39

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix last used and favourite tracking issues #39

merged 1 commit into from
May 20, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 20, 2024 •
edited
Loading

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski
Fix last used and favourite tracking issues:
62f44fe 
- fix last used not getting saved when kernel was created from dialog
- fix favourites not being updated when changed in another
  launcher/dialog
- fix last used not being updated for auto-started kernels
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-new-launcher/track-kernels-created-externally

@krassowski krassowski changed the title Fix last used and favourite tracking issues: Fix last used and favourite tracking issues May 20, 2024
@krassowski krassowski added the bug label May 20, 2024
@krassowski krassowski merged commit 31ee635 into main May 20, 2024
10 of 11 checks passed
@krassowski krassowski deleted the track-kernels-created-externally branch May 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record "last used" date for kernels that were started without the table
1 participant
@krassowski