Skip to content

Commit

Permalink
scripts/make.fsx: cosmetic, use longer flag name
Browse files Browse the repository at this point in the history
And also use dash prefix instead of slash, which is more
crossplatform friendly (because in Unix something that starts
with a slash could be a path).
  • Loading branch information
knocte committed Aug 23, 2023
1 parent 5a1047e commit 731d594
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions scripts/make.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ let BuildSolution
if buildTool.StartsWith "dotnet" then
sprintf "--configuration %s" (binaryConfig.ToString())
else
sprintf "/p:Configuration=%s" (binaryConfig.ToString())
sprintf "-property:Configuration=%s" (binaryConfig.ToString())

let defineConstantsFromBuildConfig =
match buildConfigContents |> Map.tryFind "DefineConstants" with
Expand Down Expand Up @@ -191,11 +191,11 @@ let BuildSolution
| "xbuild", _ ->
// xbuild: legacy of the legacy!
// see https://github.com/dotnet/sdk/issues/9562
sprintf "%s /p:DefineConstants=\"%s\"" configOption (String.Join(semiColonEscaped, defineConstants))
sprintf "%s -property:DefineConstants=\"%s\"" configOption (String.Join(semiColonEscaped, defineConstants))
| builtTool, Misc.Platform.Windows when buildTool.ToLower().Contains "msbuild" ->
sprintf "%s /p:DefineConstants=\"%s\"" configOption (String.Join(semiColon, defineConstants))
sprintf "%s -property:DefineConstants=\"%s\"" configOption (String.Join(semiColon, defineConstants))
| _ ->
sprintf "%s /p:DefineConstants=\\\"%s\\\"" configOption (String.Join(semiColon, defineConstants))
sprintf "%s -property:DefineConstants=\\\"%s\\\"" configOption (String.Join(semiColon, defineConstants))
else
configOption
let buildArgs = sprintf "%s %s %s %s"
Expand Down

0 comments on commit 731d594

Please sign in to comment.