Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-2679: Start consumer manglende medvirkning #432

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ingring
Copy link
Contributor

@ingring ingring commented Sep 20, 2024

Hva har blitt lagt til✨🌈

Oppdaget at de brukerne som har forhåndsvarsel på manglende medvirkning ikke dukket opp i oversikten. Vi fant ut at det var flere grunner til dette. For å fikse dette så har vi:

  • Startet consumeren
  • Gjort om personident til string
  • Lagt til unntak som vurderingstype
  • Fikset opp i copy paste feil, bruker nå vurderingRecord isteden
  • Fikset opp i skrivemåte av svarfrist (svarFrist) i recorden
  • Oppdaterte manglendeMedvirkningDTO til å passe produseren ved å endre til vurderingType, legge til veilederident. Har ignorert document som også leveres av api-et, men er ikke relevant her.

@ingring ingring requested a review from a team as a code owner September 20, 2024 12:43
@ingring ingring force-pushed the start-consumer-manglende-medvirkning branch 4 times, most recently from 64a42ac to d8d9912 Compare September 20, 2024 13:57
Copy link
Contributor

@andersrognstad andersrognstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tester feiler 🧐

@ingring ingring force-pushed the start-consumer-manglende-medvirkning branch from d8d9912 to 53323a4 Compare September 23, 2024 09:51
@ingring ingring changed the title Start consumer manglende medvirkning IS-2679: Start consumer manglende medvirkning Sep 23, 2024
@ingring ingring force-pushed the start-consumer-manglende-medvirkning branch from 53323a4 to 5621728 Compare September 23, 2024 10:27
@ingring ingring force-pushed the start-consumer-manglende-medvirkning branch from 5621728 to 588cad8 Compare September 23, 2024 11:06
@@ -28,5 +29,5 @@ data class ManglendeMedvirkningVarselDTO(
)

enum class ManglendeMedvirkningVurderingType {
FORHANDSVARSEL, OPPFYLT, STANS, IKKE_AKTUELL,
FORHANDSVARSEL, OPPFYLT, STANS, IKKE_AKTUELL, UNNTAK
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt kjipt at vi må huske på å oppdatere her når det blir flere typer.

@ingring ingring merged commit b683bd5 into master Sep 23, 2024
4 checks passed
@ingring ingring deleted the start-consumer-manglende-medvirkning branch September 23, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants