Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace custom TokenExchangeGrant with Nimbus SDK grant #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: replace custom TokenExchangeGrant with Nimbus SDK grant #732

wants to merge 2 commits into from

Conversation

tommytroen
Copy link
Collaborator

  • breaking: TokenExchangeGrant.kt has been removed in favor of com.nimbusds.oauth2.sdk.tokenexchange.TokenExchangeGrant, this affects the extension function fun TokenRequest.tokenExchangeGrantOrNull()
  • use nimbus sdk to construct tokenRequest for token_exchange
  • remove use of deprecated constructors for nimbus TokenRequest
  • formatting

@tommytroen
refactor: replace custom TokenExchangeGrant with Nimbus SDK grant
781776c 
* breaking: TokenExchangeGrant.kt has been removed in favor of com.nimbusds.oauth2.sdk.tokenexchange.TokenExchangeGrant, this affects the extension function fun TokenRequest.tokenExchangeGrantOrNull()
* use nimbus sdk to construct tokenRequest for token_exchange
* remove use of deprecated constructors for nimbus TokenRequest
* formatting
@tommytroen tommytroen requested a review from a team as a code owner August 21, 2024 07:01
@tommytroen tommytroen added the breaking breaking changes, i.e. non backwards compatible api changes label Aug 21, 2024
@github-actions github-actions bot added the stale label Sep 9, 2024
@github-actions github-actions bot closed this Sep 20, 2024
@tronghn tronghn reopened this Sep 23, 2024
@tronghn tronghn removed the stale label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybelMekk ybelMekk ybelMekk approved these changes

Assignees
No one assigned
Labels
breaking breaking changes, i.e. non backwards compatible api changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommytroen @ybelMekk @tronghn