Skip to content

Commit

Permalink
Refactor and rename
Browse files Browse the repository at this point in the history
  • Loading branch information
richardborge committed Jun 23, 2021
1 parent d2e02c4 commit 997a801
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions src/main/kotlin/no/nav/klage/oppgave/service/MottakService.kt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import no.nav.klage.oppgave.exceptions.OversendtKlageNotValidException
import no.nav.klage.oppgave.repositories.EnhetRepository
import no.nav.klage.oppgave.repositories.MottakRepository
import no.nav.klage.oppgave.util.getLogger
import no.nav.klage.oppgave.util.isValidFnr
import no.nav.klage.oppgave.util.isValidFnrOrDnr
import org.springframework.context.ApplicationEventPublisher
import org.springframework.core.env.Environment
import org.springframework.stereotype.Service
Expand Down Expand Up @@ -75,8 +75,8 @@ class MottakService(

fun OversendtKlage.validate() {
tilknyttedeJournalposter.forEach { validateJournalpost(it.journalpostId) }
validateKlager(klager.id)
sakenGjelder?.run { validateKlager(sakenGjelder.id) }
validatePartId(klager.id)
sakenGjelder?.run { validatePartId(sakenGjelder.id) }
validateTema(tema)
validateType(type)
validateEnhet(avsenderEnhet)
Expand Down Expand Up @@ -117,12 +117,12 @@ class MottakService(
throw OversendtKlageNotValidException("$journalpostId er ikke en gyldig journalpost referanse")
}

private fun validateKlager(klager: OversendtPartId) {
private fun validatePartId(klager: OversendtPartId) {
if (klager.type == OversendtPartIdType.VIRKSOMHET) {
return
}

if (!isValidFnr(klager.verdi)) {
if (!isValidFnrOrDnr(klager.verdi)) {
throw OversendtKlageNotValidException("Ugyldig fødselsnummer")
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package no.nav.klage.oppgave.util

fun isValidFnr(fnr: String): Boolean {
fun isValidFnrOrDnr(fnr: String): Boolean {
if (fnr.length != 11) {
return false
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ package no.nav.klage.oppgave.util
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test

class FnrUtilTest {
class IdentUtilTest {

@Test
fun `ugyldig fødselsnummer gir feil`() {
assertThat(isValidFnr("12345678910")).isFalse
assertThat(isValidFnrOrDnr("12345678910")).isFalse
}

@Test
fun `gyldig fødselsnummer gir rett svar`() {
assertThat(isValidFnr("02446701749")).isTrue
assertThat(isValidFnrOrDnr("02446701749")).isTrue
}

}

0 comments on commit 997a801

Please sign in to comment.