-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dockerimage #3160
Upgrade dockerimage #3160
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently building all packages with "LTS" version of node
- uses: actions/setup-node@v4
with:
node-version: lts/*
cache: yarn
LTS is currently v20, and v22 won't be LTS until October Should we update the workflow to build everything with latest version of v22? Or just use gcr.io/distroless/nodejs20-debian12
?
Good question. On one hand, if we hard code the version in the workflows, we have more places to update. But then we assure consistent versions. On the other hand, if we keep lts we only need to ever update Dockerfile. Do you think there's a risk of errors by using different versions in workflows vs. Docker? |
https://github.com/GoogleContainerTools/distroless/tree/main?tab=readme-ov-file#what-images-are-available