Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dockerimage #3160

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Upgrade dockerimage #3160

merged 3 commits into from
Sep 19, 2024

Conversation

HalvorHaugan
Copy link
Contributor

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 2661ac2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently building all packages with "LTS" version of node

- uses: actions/setup-node@v4
        with:
          node-version: lts/*
          cache: yarn

LTS is currently v20, and v22 won't be LTS until October Should we update the workflow to build everything with latest version of v22? Or just use gcr.io/distroless/nodejs20-debian12?

@HalvorHaugan
Copy link
Contributor Author

We are currently building all packages with "LTS" version of node

- uses: actions/setup-node@v4
        with:
          node-version: lts/*
          cache: yarn

LTS is currently v20, and v22 won't be LTS until October Should we update the workflow to build everything with latest version of v22? Or just use gcr.io/distroless/nodejs20-debian12?

Good question. On one hand, if we hard code the version in the workflows, we have more places to update. But then we assure consistent versions. On the other hand, if we keep lts we only need to ever update Dockerfile. Do you think there's a risk of errors by using different versions in workflows vs. Docker?

@HalvorHaugan HalvorHaugan enabled auto-merge (squash) September 19, 2024 13:06
@HalvorHaugan HalvorHaugan merged commit cd9dc04 into main Sep 19, 2024
6 checks passed
@HalvorHaugan HalvorHaugan deleted the upgrade-dockerimage branch September 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants