Change references to ="$(expression)" from =$(expression) in scripts #713
Conversation
bin/run-command
Outdated
| @@ -88,18 +88,18 @@ overrides=$(cat << EOF | |||
| ] | |||
| } | |||
| EOF | |||
| ) | |||
| )" | |||
There was a problem hiding this comment.
I'm not sure about this one? It might because the exception since there's an EOF involved
bin/update-pr-environment
Outdated
| <!-- begin PR environment info --> | ||
| ## Preview environment | ||
| - Service endpoint: ${service_endpoint} | ||
| - Deployed commit: ${image_tag} | ||
| <!-- end PR environment info --> | ||
| EOF | ||
| ) | ||
| )" |
There was a problem hiding this comment.
Same opinion as above about the EOF
There was a problem hiding this comment.
This LGTM, but I want @lorenyu to chime in about whether or not we should retest all these scripts. That seems like a like of work for a change of this small size.
|
@aplybeah sorry I totally missed this PR, please ping me again if you don't get a response, don't let PRs just sit around as the PR author you're ultimately responsible for driving things to completion. Please follow the template development workflow and create a platform-test PR with these changes so that we can see that these changes all pass in CI, and post a link to that PR in this one. |
Ticket
Resolves #669
Changes
Context for reviewers
This is related to the changes made in #661
Testing
N/A