[Issue #358]: Add e2e tests against PR preview env #85
Conversation
roll capture service endpoint into update environment step Co-authored-by: Loren Yu <[email protected]>
.github/workflows/e2e-tests.yml
Outdated
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install system dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libwoff1 libopus0 libvpx7 libevent-2.1-7 libopus0 libgstreamer1.0-0 \ | ||
| libgstreamer-plugins-base1.0-0 libgstreamer-plugins-good1.0-0 libharfbuzz-icu0 libhyphen0 \ | ||
| libenchant-2-2 libflite1 libgles2 libx264-dev | ||
|
|
||
| - name: Install Node.js dependencies | ||
| run: npm ci | ||
| working-directory: ./e2e | ||
|
|
||
| - name: Install Playwright browsers | ||
| run: npx playwright install --with-deps | ||
| working-directory: ./e2e |
There was a problem hiding this comment.
Ok.. there are a lot more dependencies here than I expected. Installing linux packages, node libraries, and browsers. Given how much there is here we should containerize this and run it all in a container, like we do with unit tests. Makes me think that we should consider Dockerizing this like we do for unit tests in the Flask template. Does Playwright run ok in a Docker container?
cc @rocketnova what do you think?
That said I'd be open to doing that in a separate PR.
There was a problem hiding this comment.
I would vote separate pr as this is getting large
| sudo apt-get update | ||
| sudo apt-get install -y libwoff1 libopus0 libvpx7 libevent-2.1-7 libopus0 libgstreamer1.0-0 \ | ||
| libgstreamer-plugins-base1.0-0 libgstreamer-plugins-good1.0-0 libharfbuzz-icu0 libhyphen0 \ | ||
| libenchant-2-2 libflite1 libgles2 libx264-dev |
There was a problem hiding this comment.
What are these for? Does it merit a comment or link to documentation that explains the need for these packages and/or what they do?
There was a problem hiding this comment.
If it helps, you can see the initial deps failure here: https://github.com/navapbc/platform-test-nextjs/actions/runs/9885358319/job/27303354260
Co-authored-by: Loren Yu <[email protected]>
…navapbc/platform-test-nextjs into rylew/358-e2e-tests-preview-env
|
Moved over to template-infra repo navapbc/template-infra#694 |
Ticket
Resolves #358
Changes
Context
template-infra[Demo]: Updated e2e tests with changes from template-infra #86template-infraPR to be merged: Add e2e tests template-infra#694Preview environment