DST-252: set up code for accordion implementation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccheng26
commented
Jun 14, 2024
| @@ -44,9 +44,8 @@ async def init_chat(): | |||
| } | |||
|
|
|||
| await cl.Message( | |||
| metadata=metadata, | |||
There was a problem hiding this comment.
removed due to unexpected key error
ccheng26
commented
Jun 14, 2024
| @@ -47,8 +46,8 @@ def chat_engine(self): | |||
|
|
|||
| # This function cannot be async because it uses a single non-thread-safe app_state | |||
| @app.post("/query") | |||
| def query(message: str | Dict): | |||
| response = app_state.chat_engine().gen_response(message) | |||
| def query(message: str): | |||
There was a problem hiding this comment.
removed Dict type, causes error in populate_summaries in ll 196, key errors for gen_results.question
There was a problem hiding this comment.
This fixed the underlying error? I'm a bit surprised, since I didn't think type annotations could affect runtime!
KevinJBoyer
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #DST-252
Changes
.tomlfileTesting
Testing instructions and expected behavior:
For API:
pip install -r requirements.txt.env./ingest-guru-cards.py/chatbot_api.pylocalhost:8001/queryFor chainlit UI:
pip install -r requirements.txt.env./ingest-guru-cards.py./chatbot-chainlit.py