-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concrete errors to Object Store #1015
Conversation
Signed-off-by: Tomasz Pietrek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming nit
@@ -457,7 +522,7 @@ pub struct List<'a> { | |||
} | |||
|
|||
impl Stream for List<'_> { | |||
type Item = Result<ObjectInfo, Error>; | |||
type Item = Result<ObjectInfo, ListerError>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type Item = Result<ObjectInfo, ListerError>; | |
type Item = Result<ObjectInfo, ListError>; |
} | ||
|
||
#[derive(Debug)] | ||
pub struct WatcherError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub struct WatcherError { | |
pub struct WatchError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Tomasz Pietrek [email protected]