Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SDR variable names and correct typo in docstring #1629 #1638

Merged
merged 1 commit into from
Oct 8, 2024
Merged

update SDR variable names and correct typo in docstring #1629 #1638

merged 1 commit into from
Oct 8, 2024

Conversation

emlys
Copy link
Member

@emlys emlys commented Oct 7, 2024 •
edited
Loading

Description

Fixes #1629
Making the changes suggested by @lmandle

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@emlys emlys marked this pull request as ready for review October 7, 2024 21:18
@emlys emlys requested a review from dcdenu4 October 7, 2024 21:18
@emlys emlys self-assigned this Oct 7, 2024
dcdenu4
dcdenu4 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @emlys

@dcdenu4 dcdenu4 merged commit 91e10fb into natcap:main Oct 8, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcdenu4 dcdenu4 dcdenu4 approved these changes

Assignees

@emlys emlys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small typos/mis-match with user's guide in sdr_core.pyx comments?
2 participants
@emlys @dcdenu4