Fix autotest failures on main
#1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemfish
requested changes
Sep 12, 2024
| import sys | ||
|
|
||
| # We want to guarantee that this is called BEFORE any other processes start, | ||
| # which could happen at import time. |
There was a problem hiding this comment.
If another process was starting at import time, would that be an indication that the code starting that process belongs under an if __name__ == '__main__' ? Maybe it's outside of our control though?
.github/workflows/build-and-test.yml
Outdated
| @@ -196,7 +196,7 @@ jobs: | |||
| - name: Check long description with twine | |||
| run: twine check $(find dist -name "natcap[._-]invest*") | |||
|
|
|||
| - uses: actions/upload-artifact@v3 | |||
| - uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: Source distribution | |||
There was a problem hiding this comment.
It looks like there's a breaking change here: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
I guess we'll have to rename the artifact. Using matrix.os and matrix.python-version should do it.
…rgogh/invest into bugfix/1622-autotest-failing-on-main
davemfish
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the multiprocessing freeze support call to
__main__.py, which addresses the autotest issue as demonstrated by the GHA logs here: https://github.com/phargogh/invest/actions/runs/10821260328/job/30022930272 (I had to force the autotest to happen since it doesn't usually run on most pushes).I also noticed a bunch of warnings related to outdated versions of actions steps, so I just went ahead and updated those as well.
Fixes #1622
Checklist
- [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)- [ ] Updated the user's guide (if needed)- [ ] Tested the Workbench UI (if relevant)