Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdist version information in github actions sdist builds #1584

Merged
merged 3 commits into from
May 28, 2024
Merged

Fix sdist version information in github actions sdist builds #1584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e860f81
Fixing an issue resulting in incorrect version information in an SDIST.
phargogh May 28, 2024
94d2612
Elevating warnings to errors to catch sdist build issues. RE:#1581
phargogh May 28, 2024
2284cfb
Correcting yaml syntax. RE:#1581
phargogh May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ jobs:
os: [windows-latest, macos-latest]
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Fetch complete history for accurate versioning

- uses: ./.github/actions/setup_env
with:
Expand All @@ -176,7 +178,9 @@ jobs:
# computer is guaranteed to have cython available at build
# time. Thus, it is no longer necessary to distribute the
# .cpp files in addition to the .pyx files.
python -m build --sdist
#
# Elevating any python warnings to errors to catch build issues ASAP.
python -W error -m build --sdist

- name: Install from source distribution
run : |
Expand Down
Loading