upgraded eslint packages to latest available #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…waitFor does not timeout. natcap#1470
davemfish
commented
Mar 11, 2024
| @@ -227,7 +227,7 @@ describe('Sidebar Buttons', () => { | |||
| const response = 'saved'; | |||
| archiveDatastack.mockImplementation(() => new Promise( | |||
| (resolve) => { | |||
| setTimeout(() => resolve(response), 1000); | |||
| setTimeout(() => resolve(response), 500); | |||
There was a problem hiding this comment.
This test failed once intermittently. I think the waitFor at line 245 times out after 1000ms by default, and it was trying to wait for this to resolve, so it was hit/miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of these packages was not compatible with
node v20, now it is. I also ran the checks on node 18 before upgrading to 20. So I think we should be compatible with both now.Some of the cascading version changes seemed to impact jest. Mocking behavior changed somehow and one test was failing, so I updated our jest config to resolve that. I assume we were somehow depending on a bug that got fixed.
Checklist