Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal (and bugfix) to implement value-based conditional requirement #1511

Merged
merged 34 commits into from
Mar 11, 2024
Merged

Proposal (and bugfix) to implement value-based conditional requirement #1511

merged 34 commits into from
Mar 11, 2024

Commits on Jan 24, 2024

  1. Varname mangling for value-based conditional req. 

    RE:natcap#1503
    @phargogh
    phargogh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    845c49f View commit details
    Browse the repository at this point in the history

  2. Forgot a few docstrings. RE:natcap#1503

    @phargogh
    phargogh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    969ef23 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/natcap/invest into bugfix/1… 

    …509-una-validation-missing-uniform-search-radius
    @phargogh
    phargogh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    273ef3f View commit details
    Browse the repository at this point in the history

  4. Noting change in HISTORY. RE:natcap#1509

    @phargogh
    phargogh committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6096ad6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'main' into bugfix/1509-una-validation-missing-uniform-s… 

    …earch-radius
    @phargogh
    phargogh authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    85d8028 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Reworking sufficiency for clarity. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    66f1490 View commit details
    Browse the repository at this point in the history

  2. Reworking comprehensions into standard loop for readability. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    37a0338 View commit details
    Browse the repository at this point in the history

  3. Reworking conditional requirement. 

    Conditional requirement now evaluates the truthiness of the expression
based on the value of the parameter. If the parameter is missing, that
parameter's value is Falsy. RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e1bef80 View commit details
    Browse the repository at this point in the history

  4. Removing .value in UNA conditional requirement. 

    The latest update to using truthiness in conditional requirement
expressions handles all of these cases.

RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    658748d View commit details
    Browse the repository at this point in the history

  5. Removing the variable name rewriting. 

    This ended up not being needed if we just work directly with truthiness.
RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0ce3303 View commit details
    Browse the repository at this point in the history

  6. Slight refactor for efficiency. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    041f411 View commit details
    Browse the repository at this point in the history

  7. First stab at rewriting nested cond. requirement. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4a1f548 View commit details
    Browse the repository at this point in the history

  8. Removing unnecessary conditional requirement - table already required… 

    …. RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    416240d View commit details
    Browse the repository at this point in the history

  9. Clarifying varnames, copying spec to avoid modifying by reference, no… 

    …ting tests to write. RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    21ae820 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'bugfix/1509-una-validation-missing-uniform-search-radiu… 

    …s' of github.com:phargogh/invest into bugfix/1509-una-validation-missing-uniform-search-radius
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b5a98a4 View commit details
    Browse the repository at this point in the history

  11. Adding a test for vector field validity. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4135eec View commit details
    Browse the repository at this point in the history

  12. Adding a test for csv column conditional validity. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0b9111f View commit details
    Browse the repository at this point in the history

  13. Correcting WKT syntax. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    5e6e35b View commit details
    Browse the repository at this point in the history

  14. Adding a test for CSV row conditional validation. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b02b49c View commit details
    Browse the repository at this point in the history

  15. Fixing expression in UCM. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fec802a View commit details
    Browse the repository at this point in the history

  16. Fixing operands in wind energy expression. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f8497f6 View commit details
    Browse the repository at this point in the history

  17. Removing a comment that is no longer relevant. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cb70a12 View commit details
    Browse the repository at this point in the history

  18. Switching bitwise operations to python bools. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ecdc498 View commit details
    Browse the repository at this point in the history

  19. Correcting boolean operator and->or. RE:natcap#1509

    @phargogh
    phargogh committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bf55a26 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Light linting, mostly around line length. RE:natcap#1509

    @phargogh
    phargogh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    482b327 View commit details
    Browse the repository at this point in the history

  2. Removing a deprecated line. RE:natcap#1509

    @phargogh
    phargogh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b32fcbf View commit details
    Browse the repository at this point in the history

  3. Simplifying validate(). RE:natcap#1509

    @phargogh
    phargogh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1deee3e View commit details
    Browse the repository at this point in the history

  4. Adding directory axis. RE:natcap#1509

    @phargogh
    phargogh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    880e31f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Casting to bool outside of the expression. RE:natcap#1509

    @phargogh
    phargogh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d70b15d View commit details
    Browse the repository at this point in the history

  2. Small test fix from slight return value change. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    831fd99 View commit details
    Browse the repository at this point in the history

  3. HQ validation now partially covered by expressions. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4b6f932 View commit details
    Browse the repository at this point in the history

  4. Clarifying set names, restoring falsey exclusion. 

    Set names are now clearer, and type-specific validation will no longer
take place if the value is falsey.

RE:natcap#1509
    @phargogh
    phargogh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    617e76d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Noting changes in history. 

    RE:natcap#1509
    @phargogh
    phargogh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    03c7fb0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into bugfix/1509-una-validation-missing-uniform-s… 

    …earch-radius
    @phargogh
    phargogh authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c49c398 View commit details
    Browse the repository at this point in the history