-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urban Nature Access - Split radii by population groups #1150
Urban Nature Access - Split radii by population groups #1150
Conversation
…722-urban-nature-access-model-split-pop-and-radii
…722-urban-nature-access-model
…722-urban-nature-access-model-split-pop-and-radii
…argogh/invest into feature/722-urban-nature-access-model
…argogh/invest into feature/722-urban-nature-access-model-split-pop-and-radii
Radius mode will control which of the optional modules will operate. RE:natcap#722
This is for split population,radii, specifically. RE:natcap#722
Refactor improves readability and eliminates the possibility of a NaN getting into the search radii. RE:natcap#722
This way, the radius definition mode will be able to produce exactly the vector needed with whatever fields and/or calculations are needed for the model RE:natcap#722
The search radius modes with per-greenspace radii and uniform radius define a few rasters in exactly the same way, so this moves those steps into a shared place in the task execution tree so they only need to be defined once. RE:natcap#722
…ii' of github.com:phargogh/invest into feature/722-urban-nature-access-model-split-pop-and-radii Conflicts: src/natcap/invest/urban_nature_access.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phargogh, just getting around to taking a look at the testing. Just a few comments below.
- Looks like
pandas.testing
is not used - I noticed a few tests for
density
anddichotomous
kernels but notexponential
,gaussian
, orpower
. Was just wondering if all the kernels should have a test (for consistency) or if there was a reason for singling those ones out.
That's it!
Also fixes a bug revealed by the test. RE:natcap#722
Thanks @dcdenu4 ! I added a couple changes to:
So, I think I've responded to everything so far! But there are still a couple things that have come out of this review so far that I think would benefit from their own PRs:
So aside from these things, I'm happy to have this merged into the feature branch if you are! |
Per request by Yingjie. RE:natcap#722
@dcdenu4 and I decided that because the power function is incompletely specified in the design document and it'll take a little work to implement properly, and also because the core model parts are working even without the power kernel. The power kernel can, if needed, be added in to the model later on, like in a bugfix release. RE:natcap#722
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phargogh, I am happy to merge this into the feature branch and tackle the remaining issues in separate PRs.
This PR implements the final optional module in the Urban Nature Access model.
RE: #722
Checklist