Tutorial updates #17
Merged
Tutorial updates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarram
reviewed
Sep 28, 2017
realtime-telemetry-plugin.js
Outdated
| @@ -20,22 +18,11 @@ function RealtimeTelemetryPlugin() { | |||
| return domainObject.type === 'example.telemetry'; | |||
| }, | |||
| subscribe: function (domainObject, callback, options) { | |||
There was a problem hiding this comment.
@larkin The options argument is no longer needed since the recent changes to the telemetry API doesn't require it.
psarram
reviewed
Sep 28, 2017
example-server/realtime-server.js
Outdated
| router.ws('/', function (ws) { | ||
| var unlisten = spacecraft.listen(notifySubscribers); | ||
| subscribed = {}, // Active subscriptions for this connection | ||
| handlers = { // Handlers for specific requests |
There was a problem hiding this comment.
@larkin var is missing at line 9.
|
@psarram this looks good. When we merge this we also have to update tags for the steps. Can you merge locally, generate new tags, and push new master + new tags together? |
Closed
Simplify realtime provider Due to nasa/openmct#1594 we no longer need to worry about multiple calls for the same identifier. Host all routes on same port, use host-relative urls for client Update readme
psarram
force-pushed
the
tutorial-updates
branch
from
00df420
to
b1c24b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates based on revisions to openmct APIs.