Update UMM-Var documentation following OB DAAC feedback. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenlittlejohns
commented
Mar 15, 2024
| "from cmr import CMR_UAT\n", | ||
| "\n", | ||
| "from varinfo import VarInfoFromNetCDF4\n", | ||
| "from varinfo.umm_var import get_umm_var, publish_umm_var" |
There was a problem hiding this comment.
I made a minor tweak to the code here to include the imports and instantiation of the VarInfoFromNetCDF4 object just so the workflow didn't depend on anything outside of this section of the notebook.
owenlittlejohns
commented
Mar 15, 2024
| "from varinfo.umm_var import (get_all_umm_var, get_umm_var, publish_all_umm_var,\n", | ||
| " publish_umm_var)" | ||
| "from varinfo.cmr_search import download_granule, get_granules, get_granule_link\n", | ||
| "from varinfo.umm_var import get_all_umm_var, publish_all_umm_var, publish_umm_var" |
There was a problem hiding this comment.
These changes just strip out the stuff that is only used in workflow 3 (single UMM-Var record), as those are now imported there, so each workflow is self-contained.
flamingbear
approved these changes
Mar 15, 2024
eni-awowale
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the documentation for the notebook detailing the publication of UMM-Var records. The main aim of this PR is to make it clearer when it is preferable to use each of the workflows. There are no significant code changes.
Jira Issue ID
N/A
Local Test Steps
Proofread the notebook to check it makes sense.
PR Acceptance Checklist
Jira ticket acceptance criteria met.CHANGELOG.mdupdated to include high level summary of PR changes.VERSIONupdated if publishing a release.Tests added/updated and passing.