Add requests to requirements.txt. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flamingbear
approved these changes
Feb 21, 2024
eni-awowale
reviewed
Feb 21, 2024
owenlittlejohns
force-pushed
the
update-requirements
branch
from
2cbba0e
to
c9995de
Compare
eni-awowale
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue that @eni-awowale found. We explicitly call the
requestspackage in the UMM-Var and CMR related work added in PI 23.4, but we only have that available as a dependency of another package. To fix that, I've addedrequestsexplicitly to ourrequirements.txt. Thanks, @eni-awowale, for finding this!I'm not sure what people thing about cutting a release, as it's kind of a no-op change?
Jira Issue ID
N/A
Local Test Steps
make install && make test. The tests should pass.PR Acceptance Checklist
Jira ticket acceptance criteria met.CHANGELOG.mdupdated to include high level summary of PR changes.VERSIONupdated if publishing a release. Thoughts on this?added/updated andpassing.Documentation updated (if needed).