-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Das 2008/get edl token from launchpad token #17
Das 2008/get edl token from launchpad token #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Eni, looks pretty good. I had a few questions and suggestions for you. But I wanted to get this back to you before I tried to test it so you could work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, I think this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly just nits. The main themes:
- Probably want to bump the
version.txt
file to release this when it is merged. - Considering specific exception types in your
try
/except
around the call to URS. - Probably not renaming
auth_header
just yet, as it could still beBearer <EDL token>
. (But we're pretty close to being able to deprecate that option)
Generally, though, this is great! LaunchPad tokens are a pain, but this code makes sense and I think makes it clear which tasks need one versus an EDL bearer token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the quick updates for my minor nits.
Thanks everyone! Ready set LaunchPad 🚀! |
Description
This PR updates
varinfo.cmr_search
to include functionality to get a users EDL token given a LaunchPad token withget_edl_token_from_launchpad
andget_edl_token_header
.Jira Issue ID
DAS-2008
Local Test Steps
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.VERSION
updated if publishing a release.