Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4071: Improve the display of the Harmony tooltip #1807

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

daniel-zamora
Copy link
Contributor

@daniel-zamora daniel-zamora commented Oct 9, 2024

Overview

What is the feature?

Taking a second look at and improving the tool tip for the harmony access method.

What is the Solution?

We added a link to the harmony landing page mainly, there are some mild adjustments to margin and link color as well.

What areas of the application does this impact?

AccessMethod and AccessMethodRadio

Testing

Reproduction steps

  • Environment for testing: prod
  • Collection to test with: C1996881146-POCLOUD
  1. Select granules and progress to project page
  2. Open up the access method component and mouse over/hover the ? icon to display the tooltip

Attachments

Before:
Screenshot 2024-10-09 at 8 21 55 AM

After:
Screenshot 2024-10-09 at 8 22 01 AM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@daniel-zamora daniel-zamora changed the title EDSC-4071 improves harmony access method tool tip EDSC-4071: Improve the display of the Harmony tooltip Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (8114767) to head (1cf0321).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   93.38%   93.37%   -0.02%     
==========================================
  Files         765      765              
  Lines       18451    18452       +1     
  Branches     4761     4759       -2     
==========================================
- Hits        17231    17229       -2     
- Misses       1136     1175      +39     
+ Partials       84       48      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


beforeEach(() => {
global.ResizeObserver = ResizeObserver
jest.clearAllMocks()
})

jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn(() => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should allow you to remove all of the repeated calls to AccessMethodRadio.mockImplementation(...)

Suggested change
jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn(() => (
jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn().mockImplementation(
jest.requireActual('../../FormFields/AccessMethodRadio/AccessMethodRadio').AccessMethodRadio
))```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the swodlr mock does this, missed that

@daniel-zamora daniel-zamora marked this pull request as ready for review October 10, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants