-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4071: Improve the display of the Harmony tooltip #1807
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 93.38% 93.37% -0.02%
==========================================
Files 765 765
Lines 18451 18452 +1
Branches 4761 4759 -2
==========================================
- Hits 17231 17229 -2
- Misses 1136 1175 +39
+ Partials 84 48 -36 ☔ View full report in Codecov by Sentry. |
|
||
beforeEach(() => { | ||
global.ResizeObserver = ResizeObserver | ||
jest.clearAllMocks() | ||
}) | ||
|
||
jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn(() => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should allow you to remove all of the repeated calls to AccessMethodRadio.mockImplementation(...)
jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn(() => ( | |
jest.mock('../../FormFields/AccessMethodRadio/AccessMethodRadio', () => jest.fn().mockImplementation( | |
jest.requireActual('../../FormFields/AccessMethodRadio/AccessMethodRadio').AccessMethodRadio | |
))``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the swodlr mock does this, missed that
Overview
What is the feature?
Taking a second look at and improving the tool tip for the harmony access method.
What is the Solution?
We added a link to the harmony landing page mainly, there are some mild adjustments to margin and link color as well.
What areas of the application does this impact?
AccessMethod and AccessMethodRadio
Testing
Reproduction steps
Attachments
Before:
After:
Checklist